search

openconfig / reference

This repository contains reference implementations, specifications and tooling related to OpenConfig-based network management.
Apache License 2.0
155 stars 88 forks source link

Allow Aggregation (Atomic) in Models #161

Closed gwizdms closed 2 years ago

gwizdms commented 2 years ago

When allow aggregation is set in the SubscriptionList how does the model (schema) know where to aggregate? Researching the model library only openconfig-messages.yang signals for aggregation with oc-ext:telemetry-atomic. I could not find this reference in any other model.

From gnmi.proto: // Whether elements of the schema that are marked as eligible for aggregation // should be aggregated or not. bool allow_aggregation = 6;

From oc-ext: extension telemetry-atomic { description "The telemetry-atomic annotation is specified in the context of a subtree (containre, or list), and indicates that all nodes within the subtree are always updated together within the data model. For example, all elements under the subtree may be updated as a result of a new alarm being raised, or the arrival of a new protocol message. Transport protocols may use the atomic specification to determine optimisations for sending or storing the corresponding data.";

Also, if allow_agreggation is not set then the server or device (Target) should not be aggregating values. Correct?

gwizdms commented 2 years ago

Comment place on PR#162 as this is related. Will close this out and use PR#162 to reference.