search

openconfig / reference

This repository contains reference implementations, specifications and tooling related to OpenConfig-based network management.
Apache License 2.0
155 stars 88 forks source link

Adjust gNMI SetRequest Update handling for list keys + value payloads #176

Open earies opened 1 year ago

earies commented 1 year ago

Clarify that an Update to a list member targeted in the Path cannot include those list keys in the value payload either as a direct descendant or ultimate leafref'd node.

Since you cannot modify the list keys on a targeted Path, disallow the contents altogether in the payload. At best, the same values could be specified but since the Path is unprefixed while JSON_IETF encoding currently remains prefixed, an association needs to be drawn from a schema set perspective.

In addition, this reduces pointless and redundant bytes on the wire.

earies commented 1 year ago

@gcsl - PTAL - this just tightens up the protocol around disallowing list keys to be included in the value payload since they are immutable in this context

earies commented 1 year ago

@dplore - looking for review here. This has been a long standing PR - it looks like some protocol needs to be put in place across various repos to ensure distribution of review - Thx