search

openconfig / ygot

A YANG-centric Go toolkit - Go/Protobuf Code Generation; Validation; Marshaling/Unmarshaling
Apache License 2.0
285 stars 107 forks source link

Support mapping of protobuf lists. #915

Closed robshakir closed 1 year ago

robshakir commented 1 year ago

This PR adds support for mapping protobuf repeated fields that represent YANG lists into protobuf messages. This was an unimplemented gap previously.

The large change is due to changes in the testdata protobuf that is used for mapping.

There's a little bit of a DIFFBASE SNAFU here, where I pushed the initial PR from a fork, and this one is in openconfig/ygot. The plan will be to merge #914 and then rebase this PR onto HEAD of master.

robshakir commented 1 year ago

Thanks for the review, pushed an updated commit to address the comments.

robshakir commented 1 year ago

Upstream conflicts fixed. @wenovus - PTAL when you get a chance, thanks!

coveralls commented 1 year ago

Coverage Status

coverage: 89.52% (-0.03%) from 89.552% when pulling 27f12ede567d68f32e3e6a1da45f97013f42942b on pm2 into 5cf59cd465f05a45d210aa3ce889f5847edb2858 on master.

robshakir commented 1 year ago

Thanks very much for the swift reviews Wen :-)