Open JonasKs opened 1 month ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hello @wenovus and @robshakir - it took some time, but we finally managed to crack the code. Please review. 😊
Also tagging #645 author, @hansthienpondt.
Hi @robshakir , friendly bump in case you missed this 😊
I did miss it -- apologies, let me review ASAP.
I did miss it -- apologies, let me review ASAP.
No worries, @robshakir! We’ve been using the fork in production and it’s worked like a charm.
Closes #936.
The implementation ended up being somewhat as described in #936, where we indicate that presence container has a
nil
value in thefindSetLeaves
function.In addition to this, we added a presence container interface, which is used in the
marshalStructOrOrderedList
to isolate the presence container which might have values, to act like an empty struct.The result is that we do not break any current tests (even without the diff option), but we decided to add a diff option, with the reasoning described in #936:
We've confirmed this works in our setup. We're able to successfully configure all presence containers, even nested ones.
Co-authored-by: Terje Lafton terje@lafton.io