opencontainers / artifacts

OCI Artifacts
https://opencontainers.org
Apache License 2.0
225 stars 54 forks source link

Yes, we should delete this repository #63

Closed jdolitsky closed 1 year ago

jdolitsky commented 1 year ago

Follow up to https://github.com/opencontainers/artifacts/issues/46 and https://github.com/opencontainers/artifacts/issues/61

This repo causes lots of confusion for people asking "What is an OCI Artifact". If we need better language in image-spec/distribution spec around this definition, then we should do that instead, and redirect this to that page.

The important behavior here has been codified into distribution-spec. Please see https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pushing-manifests-with-subject

Append a descriptor for the pushed image or artifact manifest to the manifests in the referrers list. The value of the artifactType MUST be set in the descriptor to value of the artifactType in the artifact manifest, or the config descriptor mediaType in the image manifest. All annotations from the image or artifact manifest MUST be copied to this descriptor.

imjasonh commented 1 year ago

+1. I volunteered for an AI in October 2022 to identify useful information from this repo, mainly in Artifact Author Guidance, and move it into the image-spec repo, as non-spec guidance. I have totally failed to do that so far.

My findings, from reading through that whole repo:

All in all I think most of that repo can turn into a paragraph or two in either image-spec (as SHOULDs), or in a short doc about best practices for artifact type creators. That guidance should be based on real world usage in the wild.

edit: we should remove whatever content makes it over into image-spec and archive the repo with pointers to image-spec; not delete the repo entirely.

imjasonh commented 1 year ago
  • Defining a Unique Artifact Type boils down to guidance about how to construct a unique and valid IANA media type, which I think we can just link to IANA guidance on.
  • Defining layer.mediaTypes boils down to linkable IANA guidance, with the addition of the +gzip convention that should probably go ...somewhere?

I've proposed these additions to the image manifest spec here: https://github.com/opencontainers/image-spec/pull/1010 -- the +gzip guidance was already present there.

With this specified for image manifests I think we can remove any remaining guidance in the OCI artifacts repo and archive it, pointing to the image-spec repo's image manifest spec.

imjasonh commented 1 year ago

https://github.com/opencontainers/image-spec/pull/1010 was merged, and I propose we should proceed with archiving this repo, now that most of its useful information is now present in the image-spec repo.

caniszczyk commented 1 year ago

Do you want to vote on this? The TOB can vote to archive this repo, happy to do it

On Thu, Mar 30, 2023 at 9:00 AM Jason Hall @.***> wrote:

opencontainers/image-spec#1010 https://github.com/opencontainers/image-spec/pull/1010 was merged, and I propose we should proceed with archiving this repo, now that most of its useful information is now present in the image-spec repo.

— Reply to this email directly, view it on GitHub https://github.com/opencontainers/artifacts/issues/63#issuecomment-1490358510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSILKOTV2FS4FNJAQW6TW6WGZBANCNFSM6AAAAAAUQXV3IY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

sudo-bmitch commented 1 year ago

My own preference is to hold for https://github.com/opencontainers/image-spec/pull/1043 which hopefully won't be long.

imjasonh commented 1 year ago

I'm fine to wait for #1043, and then after that take it to the TOB to vote.

jdolitsky commented 1 year ago

alright, lets do the vote

jdolitsky commented 1 year ago

opened https://github.com/opencontainers/tob/issues/126

SteveLasker commented 1 year ago

Closing as this is a dupe of #61: The evolution of OCI Artifacts is being covered as a TOB Vote: https://github.com/opencontainers/tob/issues/126