search

opencontainers / artifacts

OCI Artifacts
https://opencontainers.org
Apache License 2.0
224 stars 54 forks source link

Update definitions-terms.md #64

Closed Zhurik closed 1 year ago

Zhurik commented 1 year ago

typo

imjasonh commented 1 year ago

Both of these spellings seem to be accepted as correct in common usage. I'm not sure this change is worth making.

Zhurik commented 1 year ago

Both of these spellings seem to be accepted as correct in common usage. I'm not sure this change is worth making.

The only problem is this link leads to page that doesn't exist. So I decided to match word with link

SteveLasker commented 1 year ago

Hi @Zhurik, We can do the link fix post merge, however, unfortunately, we need a signature associated with your PR See: https://github.com/opencontainers/artifacts/blob/main/CONTRIBUTING.md#sign-your-work for OCI Contributing guidelines.

And the DCO fix: See https://github.com/opencontainers/artifacts/pull/64/checks?check_run_id=13574434672

git config --global user.name "full name here"
git config --global user.email "email address here" 
git commit -s --amend
Zhurik commented 1 year ago

Hi @Zhurik, We can do the link fix post merge, however, unfortunately, we need a signature associated with your PR See: https://github.com/opencontainers/artifacts/blob/main/CONTRIBUTING.md#sign-your-work for OCI Contributing guidelines.

And the DCO fix: See https://github.com/opencontainers/artifacts/pull/64/checks?check_run_id=13574434672

git config --global user.name "full name here"
git config --global user.email "email address here" 
git commit -s --amend

Done