search

opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
828 stars 205 forks source link

Distribution spec cross blob mount test does not upload original blob #276

Closed vsoch closed 3 years ago

vsoch commented 3 years ago

I'm looking at the test here:

https://github.com/opencontainers/distribution-spec/blob/7108d95fe5fd0360d2a5084d8ceb7f37b95fbc60/conformance/02_push_test.go#L206

And I'm not seeing anywhere in the suite that this other repository blob is actually uploaded. E.g., so my registry will not find the blob and default to the next case of returning and upload session. Am I missing something?

jonjohnsonjr commented 3 years ago

I believe that happens here: https://github.com/opencontainers/distribution-spec/blob/7108d95fe5fd0360d2a5084d8ceb7f37b95fbc60/conformance/02_push_test.go#L39-L51

vsoch commented 3 years ago

Oh I see - I misread the new docs for mount and had switched the repos in the return so it was just returning the wrong name. This mount thing is new to me - sorry for the noise!