search

opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
828 stars 205 forks source link

nested go.mod may not be suitable #314

Open vbatts opened 2 years ago

vbatts commented 2 years ago

with https://github.com/opencontainers/distribution-spec/pull/283 we landed ./specs-go/go.mod.

The motivation to put it nested was to avoid pulling in deps that have nothing to do with the bare structures of the spec. But this model with modules is tricky. And even in the https://github.com/opencontainers/image-spec/pull/883 we found it simpler to just have the top level go.mod, rather than messing with a git-tag workflow, etc.

One other point, is it seems some tools like gopls do not easily handle nested go.mod files :shrug: : Screenshot from 2021-12-09 13-02-39

BenTheElder commented 1 year ago

go.work in 1.18 makes this easier while retaining the separate dependency sets.