search

opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
828 stars 205 forks source link

TAG_INVALID in conformance tests is not present is spec #319

Closed flavianmissi closed 2 years ago

flavianmissi commented 2 years ago

The TAG_INVALID error code is currently being checked by the conformance tests, but it's not mentioned in the specification.

Should TAG_INVALID be added to the spec, or should it be removed from the comformance tests?

sudo-bmitch commented 2 years ago

This was removed from the distribution-spec back in #206. Is this throwing an error for you? It may be useful for UX when interacting with registries that implement the docker registry spec.

flavianmissi commented 2 years ago

No errors no. I thought I'd bring it up because although they are accepted error codes in the conformance tests, they are not listed in the list of acceptable error codes so I was a bit confused. i.e

The code field MUST be one of the following: Except the code can also be TAG_INVALID or MANIFEST_UNVERIFIED.

Am I nitpicking?