search

opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
781 stars 201 forks source link

conformance: pull tests shouldn't rely on tag listing #476

Closed waynr closed 2 months ago

waynr commented 9 months ago

I don't have a fully-implemented container registry yet. I am implementing endpoints incrementally in order to work toward a fully-functioning implementation of the spec. This PR removes call to the tag listing endpoint that was erroneously being relied on to determine the name of a valid tag to pull.

Instead, I replaced a tag := ... with a tag = ... in an earlier ginkgo case in order to set the outer scopoed tag variable used in subsequent tagged manifest HEAD call. I suspect the tag listing endpoint was added here to address this apparent := vs = bug.

sudo-bmitch commented 9 months ago

I haven't had a chance to give this a full review, but CI is failing on the change.

waynr commented 9 months ago

@sudo-bmitch thanks for the heads up, i pushed a commit to fix it.

sudo-bmitch commented 9 months ago

The overall change LGTM. Would you squash the commits and add the DCO signoff?

https://github.com/opencontainers/distribution-spec/pull/476/checks?check_run_id=17356808821 https://github.com/opencontainers/distribution-spec/blob/main/CONTRIBUTING.md#sign-your-work

waynr commented 9 months ago

@sudo-bmitch done, thanks!