opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
781 stars 201 forks source link

fix discovery teardown #479

Closed waynr closed 7 months ago

waynr commented 9 months ago

Discovery test teardown was broken prior to this because it would attempt to delete a blob before deleting at least five manifests left over from the setup that still reference it. Most registries probably don't care about deleting content that's referenced by other content, which is probably why this works for others.

Also, I was seeing GET /v2/<name>/tags/list?n=0 requests and then out of bounds indexing into the resulting slice because of the weird logic used to calculate what the n parameter should be in the tag listing endpoint tests.

Fixes #457.

mikebrow commented 9 months ago

pls sign commits

sudo-bmitch commented 8 months ago

@waynr do you have time to work on the changes requested? If not, I can take a stab at it.

waynr commented 8 months ago

@sudo-bmitch I accepted your suggested changes, thanks for the reminder!