search

opencontainers / distribution-spec

OCI Distribution Specification
https://opencontainers.org
Apache License 2.0
780 stars 201 forks source link

Fix redaction of conformance tests #529

Closed sudo-bmitch closed 3 months ago

sudo-bmitch commented 3 months ago

Debugging the call to Debugf shows it's being called as Debugf("%s", "... logs that should be redacted ..."). Our previous redaction only ran on the format string, and not the rest of the args. This moves the redaction to run on the final logged output.

Fix #521. Replace #523.

sudo-bmitch commented 3 months ago

cc @jdolitsky @shizhMSFT .

sudo-bmitch commented 3 months ago

I did a check of the recent PRs to oci-conformance and everything is redacted there, so this would have broken sometime after November 2023.