search

opencontainers / go-digest

Common digest package used across the container ecosystem
https://www.opencontainers.org/
Other
185 stars 59 forks source link

algorithm: More new removal #10

Closed wking closed 7 years ago

wking commented 7 years ago

Fixes for #9.

stevvooe commented 7 years ago

Because this is returning a crypto.Hash, rather than a digest.Digester, this needs to be New(). This part of the reason this was renamed: it was very confusing which one was which.

wking commented 7 years ago

On Fri, Dec 16, 2016 at 04:36:20PM -0800, Stephen Day wrote:

Because this is returning a crypto.Hash, rather than a digest.Digester, this needs to be New().

Oops, thanks. Fixed in 452242f → fe5ffa6, since I think we do still want the comment fixes.

stevvooe commented 7 years ago

LGTM