opencontainers / go-digest

Common digest package used across the container ecosystem
https://www.opencontainers.org/
Other
185 stars 59 forks source link

Revert "MAINTAINERS: add new maintainers to go-digest" #26

Closed jonboulle closed 7 years ago

jonboulle commented 7 years ago

Reverts opencontainers/go-digest#25

per https://github.com/opencontainers/go-digest/pull/25#issuecomment-271591573 apparently I jumped the gun, apologies.

wking commented 7 years ago

On Tue, Jan 10, 2017 at 06:40:58AM -0800, Jonathan Boulle wrote:

Reverts opencontainers/go-digest#25

I don't know that we need to revert it, since I'd guess that the maintainer addition will pass. Maybe just ping the remaining maintainers to vote on #25 after the fact? It shouldn't take too long to collect the remaining votes needed for a quorum…

caniszczyk commented 7 years ago

I'd be OK with after the fact voting if we get people to give their LGTMs on GitHub.

jonboulle commented 7 years ago

feel free to close this if that happens, just wanted to be explicit I'm not trying to sneak anything past.

On Tue, Jan 10, 2017 at 5:21 PM Chris Aniszczyk notifications@github.com wrote:

I'd be OK with after the fact voting if we get people to give their LGTMs on GitHub.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opencontainers/go-digest/pull/26#issuecomment-271620740, or mute the thread https://github.com/notifications/unsubscribe-auth/ACewN_tRYG46SN49AJSY1aNbsIIpvpATks5rQ6-SgaJpZM4LffDo .

stevvooe commented 7 years ago

@jonboulle @caniszczyk How do we organize this? Do we solicit the LGTMs on #25?

stevvooe commented 7 years ago

@jonboulle Now that we have the 5 (retroactive :() LGTMs on #25, we can close this down.

Welcome @aaronlehmann and @dmcgowan!

wking commented 7 years ago

On Tue, Jan 10, 2017 at 08:24:43AM -0800, Jonathan Boulle wrote:

feel free to close this if that happens…

I think we can close this now, since the vote is currently +5 -0 #2 (with @stevvooe, @vbatts, @jonboulle, @brendandburns, and @jstarks in favor and @philips and @jbouzane silent). And 5/7 > 66%, so we're over quorum.

[Edit: sorry for the late comment. Should have finished clearing my inbox before posting…]