opencontainers / go-digest

Common digest package used across the container ecosystem
https://www.opencontainers.org/
Other
184 stars 60 forks source link

Update Copyrights #52

Closed vbatts closed 4 years ago

vbatts commented 4 years ago

I agree. This is mirroring the copyright in the other OCI specs. I'm not sure of the reason for the attribution to be to Linux Foundation, rather than contributors or members or such.

-------- Original Message -------- On Jan 10, 2020, 04:47, Sebastiaan van Stijn wrote:

@thaJeztah commented on this pull request.


In LICENSE:

@@ -176,6 +176,7 @@

END OF TERMS AND CONDITIONS
  • Copyright 2019, 2020 The Linux Foundation

Looking at the list of recommended options

Perhaps "Copyright 2019, 2020 The go-digest contributors" ?

(I personally like "authors" or "contributors", as it more clearly describes that copyright is not transferred to , but remains with the author/contributor)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

vbatts commented 4 years ago

updated to copyright by "OCI Contributors"

vbatts commented 4 years ago

come on @opencontainers/go-digest-maintainers ...

vbatts commented 4 years ago

(i'm wanting to cut a 1.0.0 release #46)

stevvooe commented 4 years ago

LGTM

dmcgowan commented 4 years ago

LGTM

Approved with PullApprove

vbatts commented 4 years ago

not sure why Stephen's LGTM didn't work? It was "Lgtm" to begin with, and didn't trigger the pullapprove. I edited to be "LGTM", but that also hasn't triggered..

vbatts commented 4 years ago

LGTM

Approved with PullApprove

dmcgowan commented 4 years ago

There is another PR to fix pull approve, but also pull approve doesn't work on that PR :man_facepalming:

AkihiroSuda commented 4 years ago

merge?

vbatts commented 4 years ago

@caniszczyk help?

AkihiroSuda commented 4 years ago

ping @caniszczyk 🙏

philips commented 4 years ago

LGTM (for old times sake)

Approved with PullApprove

caniszczyk commented 4 years ago

LGTM sorry, too many github notifications, message me next time :)

but yes, this falls in lines with LF guidelines https://www.linuxfoundation.org/blog/2020/01/copyright-notices-in-open-source-software-projects/