search

opencontainers / go-digest

Common digest package used across the container ecosystem
https://www.opencontainers.org/
Other
184 stars 60 forks source link

Add digestset subpackage #55

Closed dmcgowan closed 4 years ago

dmcgowan commented 4 years ago

Adds digestset from https://github.com/docker/distribution/tree/master/digestset

Originally the digest set was a part of the digest package, but was split out to make the go-digest package smaller when it moved from docker/distribution to here. This package has remained stable and used in situations when a "short" digest needs to be resolved securely and unambiguously. This package is useful alongside go-digest but can be safely broken out into a separate package, without bloating importers who do not intend to use it.

This is helpful to address some docker/distribution vendoring issues for importers who only need this package (such as containerd/containerd).

AkihiroSuda commented 4 years ago

LGTM

thaJeztah commented 4 years ago

Thanks! Looks like after this is merged, we need to do one more vendor round (containerd/cri and back)

dmcgowan commented 4 years ago

I propose we tag 1.0 after getting this merged in. Then vendoring changes can use the tag.

Toasterson commented 4 years ago

+1 from me for the 1.0 tag that makes modules behave a little better.

stevvooe commented 4 years ago

Looks like I've been removed from @opencontainers/go-digest-maintainers for some reason, so its not tracking my LGTM.

caniszczyk commented 4 years ago

added @stevvooe back and resync'd PullApprove, his next LGTM should be picked up