Add CODEOWNERS, remove .pullapprove.yml

opencontainers / go-digest

Common digest package used across the container ecosystem

https://www.opencontainers.org/

Other

184 stars 60 forks source link

Add CODEOWNERS, remove .pullapprove.yml #70

Closed jdolitsky closed 2 years ago

AkihiroSuda commented 2 years ago

What's the context?

dmcgowan commented 2 years ago

I assume to get rid of pullapprove. What does CODEOWNERS file add over just replacing pullapprove with github's threshold approve?

stevvooe commented 2 years ago

Doesn't CODEOWNERS drive github's feature?

thaJeztah commented 2 years ago

I don't think the CODEOWNERS is strictly needed to make the feature work; configuring "number of approvals" should probably be enough. That said, CODEOWNERS will allow automatically request a review from those listed.

Not sure though if "Require review from Code Owners" will force all code owners to leave a review (I guess we only need two out of that list)

caniszczyk commented 2 years ago

LGTM (enabled the "Require a pull request before merging") setting