search

opencontainers / image-spec

OCI Image Format
https://www.opencontainers.org/
Apache License 2.0
3.46k stars 636 forks source link

Update GitHub Actions packages to resolve warnings in CI #1165

Closed austinvazquez closed 7 months ago

austinvazquez commented 7 months ago

Issue:

N/A

Description:

This change updates actions/checkout to v4 and actions/setup-go to v5 to resolve NodeJS 16 deprecation warnings in CI.

Before:

image

Additional References:

austinvazquez commented 7 months ago

It looks like CI is failing due to linter version not being pinned for 1.20. Will see if I can open another PR to address.

austinvazquez commented 7 months ago

Opened https://github.com/opencontainers/image-spec/pull/1167 to resolve CI issues.

tianon commented 7 months ago

I guess this is ready for a rebase? 👀

austinvazquez commented 7 months ago

Hmm, the issue with actions/upload-artifacts@v4 seems to stem from the breaking change documented in https://github.com/actions/upload-artifact:

  1. Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

I could try 'overwrite: true' however that also means the documentation could be created by different workflow runs. e.g. Go 1.19, 1.20, 1.21. Perhaps it would be best to revert this change for now and handle separately.

sudo-bmitch commented 7 months ago
  1. Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

I can push a separate fix for that.