opencontainers / image-tools

OCI Image Tooling
https://opencontainers.org
Apache License 2.0
271 stars 82 forks source link

manpage: modify OPTIONS to FLAGS #106

Closed Mashimiao closed 7 years ago

Mashimiao commented 7 years ago

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com

xiekeyang commented 7 years ago

I think change from flag to option is OK, but this should be accordant to tools usage.

Mashimiao commented 7 years ago

I think the change does not make manpage to be not accordant with tools usage.

xiekeyang commented 7 years ago

I mean help message of tools had better to be changed accordingly(flag to option), to be like

$ ./oci-image-validate --help
Usage:  oci-image-validate FILE... [options...]
Options: ...
Mashimiao commented 7 years ago

Though I want to change all of flags to options which I think is more common. But as cobra use flags instead of options as default, it seems better to change OPTIONS to FLAGS in manpage. @xiekeyang PTAL

xiekeyang commented 7 years ago

LGTM

Approved with PullApprove

vbatts commented 7 years ago

LGTM

Approved with PullApprove