opencontainers / image-tools

OCI Image Tooling
https://opencontainers.org
Apache License 2.0
266 stars 83 forks source link

README.md: fix example #195

Closed hongchaodeng closed 6 years ago

hongchaodeng commented 6 years ago

Signed-off-by: Hongchao Deng hongchaodeng1@gmail.com

Otherwise it will error:

cannot save image with empty image.ref.name

Ref: https://github.com/projectatomic/skopeo/issues/446

Mashimiao commented 6 years ago

You need to add a Signed-off-by: line to your commit

hongchaodeng commented 6 years ago

@Mashimiao Already added but still not passed.

Mashimiao commented 6 years ago

That's because your commit's author is not the same as signed-off-by

hongchaodeng commented 6 years ago

Fixed. Thanks for your advice.

jonboulle commented 6 years ago

lgtm

Approved with PullApprove

zhouhao3 commented 6 years ago

The same question in man folder(oci-image-tool-*.md), can you fix it together?

coolljt0725 commented 6 years ago

@hongchaodeng as @q384566678 mentioned, can you also fix https://github.com/opencontainers/image-tools/blob/master/man/oci-image-tool-create.1.md#examples https://github.com/opencontainers/image-tools/blob/master/man/oci-image-tool-unpack.1.md#examples https://github.com/opencontainers/image-tools/blob/master/man/oci-image-tool-validate.1.md#examples ?

hongchaodeng commented 6 years ago

fixed

coolljt0725 commented 6 years ago

LGTM

Approved with PullApprove

zhouhao3 commented 6 years ago

LGTM

Approved with PullApprove