search

opencontainers / image-tools

OCI Image Tooling
https://opencontainers.org
Apache License 2.0
266 stars 83 forks source link

Remove Default sh in Process Args #196

Closed bkochendorfer closed 2 years ago

bkochendorfer commented 6 years ago

Defaulting to sh is not covered in the spec.

Signed-off-by: Brett Kochendorfer brett.kochendorfer@gmail.com

Closes https://github.com/opencontainers/image-tools/issues/166

bkochendorfer commented 6 years ago

Was this the right approach or not what you were looking for with regards to the issue?

zhouhao3 commented 6 years ago

Args in the spec have the following provisions:

This specification extends the IEEE standard in that at least one entry is REQUIRED,

So I think args should not be empty, if sh is wrong, Is it possible to replace sh with a correct value?

bkochendorfer commented 6 years ago

@q384566678 That's a good question. Would it be better here to complain that no arg was provided rather than defaulting to sh?