update to golang 1.11 - Githubissues

opencontainers / image-tools

OCI Image Tooling

https://opencontainers.org

Apache License 2.0

266 stars 83 forks source link

update to golang 1.11 #215

Closed zhouhao3 closed 5 years ago

zhouhao3 commented 5 years ago

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

zhouhao3 commented 5 years ago

@opencontainers/image-tools-maintainers PTAL

xiekeyang commented 5 years ago

@q384566678 commit 4775f434bc5a5f1a55505b2adddf0101d3dc46b2 might better to be another PR, right? To update to golang 1.11 one, I'm OK.

zhouhao3 commented 5 years ago

@xiekeyang The previous mistakes were all before go1.10, I don't think it makes sense to fix it again, because the version of go is updated to 1.10 in this pr.　So I think it is better to have two commits in the same pr.

zhouhao3 commented 5 years ago

I added some instructions to the commit.　@xiekeyang PTAL

xiekeyang commented 5 years ago

Got it!

LGTM