search

opencontainers / oci-conformance

OCI Conformance/Certification Working Group
https://conformance.opencontainers.org
Apache License 2.0
72 stars 42 forks source link

Failing Builds #106

Closed tianon closed 1 month ago

tianon commented 2 months ago

Recent PR merges are failing to build (and I did the merges, so I'm the lucky one getting the emails 🙃).

Someoneâ„¢ should probably look into it and see what we can do to fix it.

https://github.com/opencontainers/oci-conformance/actions/runs/9701102281/job/26790176781

sudo-bmitch commented 2 months ago

Looks like the | replace statement in the template that was just merged is breaking the Liquid processor.

vsoch commented 2 months ago

If this is jekyll it should be something like:

{{ $value.Meta.Name | downcase | replace: " ", "-" }}

Instead of {{ lower $value.Meta.Name | replace " " "-" }} That's not tested, I just pulled that out of my head, but I'm pretty sure that jekyll doesn't have lower, and then replace requires a colon and common between parameters.

vsoch commented 2 months ago

But the reference to $value has me concerned it's some turducken combination of multiple things... :grimacing:

jdolitsky commented 1 month ago

The Github Pages I am pretty sure is now handled by Netlify instead and publishing successfully to https://conformance.opencontainers.org/

Pages is/was publishing to https://opencontainers.github.io/oci-conformance/ which seems broken. I just disabled github pages in the repo settings and I'll close this issue as done.