search

opencontainers / oci-conformance

OCI Conformance/Certification Working Group
https://conformance.opencontainers.org
Apache License 2.0
71 stars 44 forks source link

Update docker/distribution workflow #55

Closed pmengelbert closed 4 years ago

pmengelbert commented 4 years ago

Build docker image from source instead of pulling pre-built image.

@caniszczyk

pmengelbert commented 4 years ago

@dmcgowan

dmcgowan commented 4 years ago

LGTM

These can only run after merge? Do you have it demonstrated working on a fork somewhere?

pmengelbert commented 4 years ago

@dmcgowan Yes, they will run after merge. I'll set up a branch with a demonstration, but please note the branch won't have access to the s3 bucket where the report lives. So the github action will "fail", but if you look at the test results they work correctly.

pmengelbert commented 4 years ago

@dmcgowan Distribution registry passing the pull workflow: https://github.com/bloodorangeio/oci-conformance/runs/731124216?check_suite_focus=true

pmengelbert commented 4 years ago

@caniszczyk This should be good to merge -- anything else you need from us?