search

opencontainers / oci-conformance

OCI Conformance/Certification Working Group
https://conformance.opencontainers.org
Apache License 2.0
72 stars 43 forks source link

Add Azure Container Registry conformance tests #87

Closed gildardogmsft closed 2 years ago

gildardogmsft commented 2 years ago

This PR adds the conformance results for Azure Container Registry

Signed-off-by: gildardogmsft gildardog@microsoft.com

netlify[bot] commented 2 years ago

✔️ Deploy Preview for oci-conformance ready!

🔨 Explore the source changes: d30e569ca691a75ed11d5c6bb1aa30130472b05e

🔍 Inspect the deploy log: https://app.netlify.com/sites/oci-conformance/deploys/61de1bad40012b00092cfdd4

😎 Browse the preview: https://deploy-preview-87--oci-conformance.netlify.app/

tianon commented 2 years ago

@jdolitsky looking at the deploy for this, the TOC link has #azurecontainerregistry but the header it's supposed to link to has id="azure-container-registry" -- that mismatch doesn't seem intentional? :sweat_smile:

tianon commented 2 years ago

I guess to be more clear -- is that a bug in the generator code, or an issue that this PR needs to fix somehow?

jdolitsky commented 2 years ago

@tianon yea.. thats gonna be generator bug we should address

gildardogmsft commented 2 years ago

Appears to be several files modified unrelated to the change.. can you please rebase @gildardogmsft ?

Sorry I pushed a faulty rebase by mistake :( I have rebased again to only include the change

vsoch commented 2 years ago

heeey I was reviewing! :cry:

tianon commented 2 years ago

Doh, sorry! I'll go a little slower on the trigger next time :see_no_evil:

(It's also not too hard to revert or re-PR if something needs to change :sweat_smile:)

vsoch commented 2 years ago

Nah it's okay, they were tiny punctuation nit picks, not really worth that.