search

opencontainers / oci-conformance

OCI Conformance/Certification Working Group
https://conformance.opencontainers.org
Apache License 2.0
72 stars 43 forks source link

Conformance Test Results for MetaHub #94

Closed ChristianKniep closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for oci-conformance ready!

Name Link
Latest commit 372e0ab0946f176868a12be1dd51983183c56929
Latest deploy log https://app.netlify.com/sites/oci-conformance/deploys/636b77e8ff24ed0008ea315c
Deploy Preview https://deploy-preview-94--oci-conformance.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ChristianKniep commented 1 year ago

DCO needs to be set on the commit (see the description on DCO error for how to fix it), and I think we want the commit message updated, too.

-s done with the last commit.

Does MetaHub not have support for any push or query operations (like listing tags), or is that support not OCI compliant?

listing tags should be included, but it's also skipped by others (bundle-bar, azure).

And a quick FYI that the site is hard to read when my desktop is in dark mode:

Yeah, I am getting my hands dirty with JavaScript - I'll get to that eventually...

sudo-bmitch commented 1 year ago

DCO needs to be set on the commit (see the description on DCO error for how to fix it), and I think we want the commit message updated, too.

-s done with the last commit.

For https://github.com/opencontainers/oci-conformance/pull/94/commits/ec3e78d8293172538fcba0b9a734a86b07b6c3a4 can you also adjust the commit messages? Should be a git rebase -i ec3e78d8293172538fcba0b9a734a86b07b6c3a4^, and then change pick to reword on the specific commit. You'll need to force push that change.

Does MetaHub not have support for any push or query operations (like listing tags), or is that support not OCI compliant?

listing tags should be included, but it's also skipped by others (bundle-bar, azure).

Bundle bar and Azure each ran the push, discovery, and management tests, which is why it stood out that MetaHub didn't.

ChristianKniep commented 1 year ago

I added the DISCOVERY tests while I was at it. Anything else I missed?

vsoch commented 1 year ago

Are we allowing squash and merge?

sudo-bmitch commented 1 year ago

Are we allowing squash and merge?

We'll find out if @jdolitsky yells at me. 😁