Open kolyshkin opened 4 years ago
Originally tacked in https://github.com/opencontainers/runc/pull/2411 but the package renaming commit removed for now.
@kolyshkin I'd like to work on this if it's something that external contributors can pick up. As you mentioned, the changes you made in libcontainers/cgroups/utils.go
still require a package rename, does it make sense for me to start from there?
Alas this is more complex than it seems. runc/libcontainer has some external users (kubernetes, cadvisor, k3s etc) and every time we make a refactor like this we have to fix all the users.
I would not touch this :)
Makes sense, that being said, would you mind If I ask you to point me to an issue that a new contributor can work on? (bg: been using runc in production for over 2 years now and would really like to contribute back). Thanks.
The following public identifiers should be moved from
github.com/opencontainers/runc/libcontainer/cgroups
to a separate package (saygithub.com/opencontainers/runc/libcontainer/cgroups/cgroupv1
). The reason is, they should only be used from cgroupv1 code (i.e. whencgroups.IsCgroup2UnifiedMode()
returnsfalse
), and they return errors otherwise.In addition, this one should be made private: