amurzeau
commented
1 year ago I found that the issue is that the cgroup is in threaded mode, and in that case, reading cgroup.procs returns ENOTSUP.
By patching runc with the following patch, tests work again and runc doesn't fail:
diff --git a/libcontainer/cgroups/utils.go b/libcontainer/cgroups/utils.go
index b32af4ee..70080efd 100644
--- a/libcontainer/cgroups/utils.go
+++ b/libcontainer/cgroups/utils.go
@@ -19,6 +19,7 @@ import (
const (
CgroupProcesses = "cgroup.procs"
+ CgroupThreads = "cgroup.threads"
unifiedMountpoint = "/sys/fs/cgroup"
hybridMountpoint = "/sys/fs/cgroup/unified"
)
@@ -137,14 +138,16 @@ func GetAllSubsystems() ([]string, error) {
}
func readProcsFile(dir string) ([]int, error) {
- f, err := OpenFile(dir, CgroupProcesses, os.O_RDONLY)
+ contents, err := ReadFile(dir, CgroupProcesses)
+ if errors.Is(err, unix.ENOTSUP) {
+ contents, err = ReadFile(dir, CgroupThreads)
+ }
if err != nil {
return nil, err
}
- defer f.Close()
var (
- s = bufio.NewScanner(f)
+ s = bufio.NewScanner(strings.NewReader(contents))
out = []int{}
)Here is the type of the cgroups (these commands were run inside the buildkit's dev-env container:
# cat /sys/fs/cgroup/buildkit/mxv4shz9kwdm0p5u49mw971ft/cgroup.type
threaded
# cat /sys/fs/cgroup/buildkit/cgroup.type
threaded
# cat /sys/fs/cgroup/cgroup.type
domain threaded
Bacto
kolyshkin
cathaysia
Description
Hi,
While testing buildkit within a docker container, tests use runc. When tring to kill a runc container, runc error out with and error like this:
read /sys/fs/cgroup/buildkit/mxv4shz9kwdm0p5u49mw971ft/cgroup.procs: operation not supportedand then return error code 1. The command line is this one:runc --root /run/containerd/runc/buildkit --log /tmp/bktest_containerd1141985211/state/io.containerd.runtime.v2.task/buildkit/mxv4shz9kwdm0p5u49mw971ft/log.json --log-format json kill --all mxv4shz9kwdm0p5u49mw971ft 9Steps to reproduce the issue
Describe the results you received and expected
Several tests using containerd fail with this error:
What version of runc are you using?
runc version v1.1.5 spec: 1.0.2-dev go: go1.20.3 libseccomp: 2.5.4
Host OS information
Host:
container running dev-env target from Dockerfile from buildkit git repository:
Host kernel information
Linux DOC-PC3 6.1.0-7-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.20-1 (2023-03-19) x86_64 GNU/Linux