search

opencontainers / runc

CLI tool for spawning and running containers according to the OCI specification
https://www.opencontainers.org/
Apache License 2.0
11.76k stars 2.09k forks source link

[ci] bats: command not found #4411

Open lifubang opened 1 hour ago

lifubang commented 1 hour ago

After merged #4409, the CI was always failed for arm64:

/bin/bash: line 1: bats: command not found

https://github.com/opencontainers/runc/actions/runs/11019452323/job/30602054521

And there are many warnings for all platform when setup bats:

/usr/bin/tar: ../../../../../usr: Cannot mkdir: Permission denied
lifubang commented 1 hour ago

@akhilerm Could you have some suggestions?

lifubang commented 1 hour ago

There are 2 problems:

  1. Known cache issue: https://github.com/bats-core/bats-action/issues/9#issuecomment-2138032932 .
  2. It seems like that there is no architecture in bats cache key. So if the bats binary has cached in amd64, it can't work on arm64 after restored from the cache. https://github.com/bats-core/bats-action/blob/main/action.yaml#L112

If the second problem is true, I think we should revert #4409 or open an issue in https://github.com/bats-core/bats-action ?

akhilerm commented 22 minutes ago

I think second problem is there, but I am still curious why we didnt hit it in the CI for the PR. Will raise an issue in bats-action to fix the same.