opencontainers / runtime-spec

OCI Runtime Specification
http://www.opencontainers.org
Apache License 2.0
3.13k stars 535 forks source link

Add Go 1.20 support #1179

Closed austinvazquez closed 1 year ago

austinvazquez commented 1 year ago

Signed-off-by: Austin Vazquez macedonv@amazon.com

austinvazquez commented 1 year ago

arf; looks like some changes are needed (see failures)

Added a little extra scope to resolve the errors. Took the opportunity to update the lint tooling from golint to golangci-lint and resolved new errors. Included here since we have the hood open but could split this into a seperate commit/PR if that helps.

austinvazquez commented 1 year ago

Adding go.mod explicitly to .gitignore is a little odd when I don't think anything here generates it (right?), but I don't care about that enough to block this.

The other combined CI fixes/updates seem fine to include here IMO 👍

Good call out I could have explained that better. CI generates them here and just wanted to be sure I didn't accidentally push those.

AkihiroSuda commented 1 year ago

Why not use go.mod ?

austinvazquez commented 1 year ago

Why not use go.mod ?

I can make this happen. IIRC other specs had them.

AkihiroSuda commented 1 year ago

@austinvazquez ↑ PTAL

austinvazquez commented 1 year ago

Changes look good overall, but they need to be structured.

  1. Fix using deprecated ioutil.
  2. Switch to using golangci-lint.
  3. Modify ci to use matrix of go versions

One other thing, for golangci-lint it is better to use their action directly from .github/workflows rather than through make.

@kolyshkin, let me draft up what golangci-lint through github action would look like and you can lmk your thoughts.

austinvazquez commented 1 year ago

@kolyshkin, I have split commits and changed linting to use github action. PTAL and let me know your thoughts.

AkihiroSuda commented 1 year ago

CI is failing

austinvazquez commented 1 year ago

CI is failing

Oof I've fallen victim to the go.mod issue. Moved the hack up to resolve.