Closed austinvazquez closed 1 year ago
arf; looks like some changes are needed (see failures)
Added a little extra scope to resolve the errors. Took the opportunity to update the lint tooling from golint to golangci-lint and resolved new errors. Included here since we have the hood open but could split this into a seperate commit/PR if that helps.
Adding
go.mod
explicitly to.gitignore
is a little odd when I don't think anything here generates it (right?), but I don't care about that enough to block this.The other combined CI fixes/updates seem fine to include here IMO 👍
Good call out I could have explained that better. CI generates them here and just wanted to be sure I didn't accidentally push those.
Why not use go.mod ?
Why not use go.mod ?
I can make this happen. IIRC other specs had them.
@austinvazquez ↑ PTAL
Changes look good overall, but they need to be structured.
- Fix using deprecated ioutil.
- Switch to using golangci-lint.
- Modify ci to use matrix of go versions
One other thing, for golangci-lint it is better to use their action directly from .github/workflows rather than through make.
@kolyshkin, let me draft up what golangci-lint through github action would look like and you can lmk your thoughts.
@kolyshkin, I have split commits and changed linting to use github action. PTAL and let me know your thoughts.
CI is failing
CI is failing
Oof I've fallen victim to the go.mod issue. Moved the hack up to resolve.
Signed-off-by: Austin Vazquez macedonv@amazon.com