search

opencontainers / runtime-spec

OCI Runtime Specification
http://www.opencontainers.org
Apache License 2.0
3.13k stars 535 forks source link

spec: add scheduler entity #1188

Closed giuseppe closed 1 year ago

giuseppe commented 1 year ago

extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall.

I've been playing with crun and it is currently implemented as an annotation:

but I think this makes sense as part of the runtime-specs without the custom hack.

rhatdan commented 1 year ago

LGTM @kolyshkin @mrunalp PTAL

utam0k commented 1 year ago

Thanks, @giuseppe

giuseppe commented 1 year ago

anything blocking or could we move forward with this PR?

giuseppe commented 1 year ago

@thaJeztah thanks for the review. Addressed your comments and pushed a new version

giuseppe commented 1 year ago

@thaJeztah does the new version look good to you?

giuseppe commented 1 year ago

@thaJeztah could you PTAL?

thaJeztah commented 1 year ago

Any more reviewers needed, or are we good to go? (forgot how many we want for such changes in this repository 🙈)

thaJeztah commented 1 year ago

Ah! Thanks @AkihiroSuda 😂