Add support for windows CPU affinity

opencontainers / runtime-spec

OCI Runtime Specification

http://www.opencontainers.org

Apache License 2.0

3.13k stars 535 forks source link

Add support for windows CPU affinity #1258

Open kiashok opened 1 week ago

kiashok commented 1 week ago

This PR adds support for certain CRI fields in OCI runtime spec for supporting CPU affinity for windows containers.

CRI PR : https://github.com/kubernetes/kubernetes/pull/124285 Github issue: https://github.com/kubernetes/kubernetes/issues/125262 KEP: https://github.com/kubernetes/kubernetes/issues/125262

kiashok commented 1 week ago

cc @jsturtevant @kevpar @aravindhp @marosset

kiashok commented 1 week ago

@AkihiroSuda @thaJeztah could you please take a look? :) thanks!

tianon commented 5 days ago

Is there a compelling reason not to roughly match the naming convention adopted for Linux in #1253?

Also, please don't mark conversations with useful discussion/links as "resolved" especially if the PR itself didn't change as a result of the discussion but the discussion is still useful and potentially something someone else might reasonably ask about or want to discuss -- it makes them much more difficult to discover when reading the PR's comments.