Windows: Typos and incorrect defaults

lowenna commented 5 years ago

Signed-off-by: John Howard jhoward@microsoft.com

There were a few typos Winodws which should be Windows (obviously).

It also corrects the defaults for Windows. Neither IgnoreFlushesDuringBoot nor networkings AllowUnqualifiedDNSQuery should be defaulted to true. Also, the assumption that there is a console is incorrect. These should all be set explicitly, if required, by callers.

@jterry75 FYI

lowenna commented 5 years ago

I'm not sure I understand what's failing in that CI run:

[0K$ git-validation -run DCO,short-subject -v -range ${TRAVIS_COMMIT_RANGE}
[31mERRO[0m[0000] mm[git] cmd: "git --no-pager log --pretty=format:%H f611b4e1e0a8b3ffd9200b35e0f4159838a1c73a...3bc60a442d30ca96277a287c8112ed4dd8541498" 
2019/02/08 02:27:03 exit status 128
travis_time:end:0f7ff500:start=1549592823782128201,finish=1549592823789607319,duration=7479118
[0K[31;1mThe command "git-validation -run DCO,short-subject -v -range ${TRAVIS_COMMIT_RANGE}" exited with 1.[0m

Yet is passes successfully locally:

jhoward@jhoward-p520:/mnt/e/go/src/github.com/opencontainers/runtime-tools$ git-validation -run DCO,short-subject -v -range f611b4e1e0a8b3ffd9200b35e0f4159838a1c73a...3bc60a442d30ca96277a287c8112ed4dd8541498
 * 3bc60a4 "Windows: Typos and incorrect defaults" ... PASS
  - PASS - has a valid DCO
  - PASS - commit subject is 72 characters or less! *yay*
jhoward@jhoward-p520:/mnt/e/go/src/github.com/opencontainers/runtime-tools$

Am I missing something obvious?

zhouhao3 commented 5 years ago

LGTM

opencontainers / runtime-tools

Windows: Typos and incorrect defaults #683