opencontainers / runtime-tools

OCI Runtime Tools
https://www.opencontainers.org/
Apache License 2.0
434 stars 141 forks source link

Add missing clone rule for s390x. Fixes #699 #700

Closed dbenoit17 closed 4 years ago

dbenoit17 commented 5 years ago

Fixes https://github.com/opencontainers/runtime-tools/issues/699

This PR adds the missing clone masked_eq seccomp rule which causes clone syscalls to fail on s390x.

I have only tested this patch directly in cri-o so far. Please consider this PR a work in progress while I become familiar with this project and its processes such as writing and running unit tests, etc.

Additionally, since this patch only affects s390x, please let me know if there is anything extra I should do to test the architecture-specific functionality.

Thanks, DB

Prashanth684 commented 4 years ago

can somebody lgtm this? we need this for s390x Openshift installations.

mrunalp commented 4 years ago

LGTM

Approved with PullApprove