AddDevice(): better diagnostic when creating dup

opencontainers / runtime-tools

OCI Runtime Tools

https://www.opencontainers.org/

Apache License 2.0

434 stars 141 forks source link

AddDevice(): better diagnostic when creating dup #701

Closed edsantiago closed 4 years ago

edsantiago commented 4 years ago

The existing diagnostic[1] appeared in a CI job with no possible hope of figuring out the source of the problem. This PR amends the diagnostic to include the name of the requested newly-created device as well as the existing "duplicate".

[1] WARNING: The same type, major and minor should not be used for multiple devices.

(I am not convinced that this condition merits a warning but will leave that discussion to better minds than mine).

Signed-off-by: Ed Santiago santiago@redhat.com

edsantiago commented 4 years ago

@q384566678 could you PTAL? Thanks in advance.

zhouhao3 commented 4 years ago

LGTM