:rotating_light: Overhaul CI steps

opencontainers / runtime-tools

OCI Runtime Tools

https://www.opencontainers.org/

Apache License 2.0

434 stars 141 forks source link

:rotating_light: Overhaul CI steps #726

Closed vbatts closed 1 year ago

vbatts commented 3 years ago

[x] remove travis (it is now defunct and blocking merges)
[x] switch to github actions
[x] switch to Github CODEOWNERS
[x] remove pullapprove

kolyshkin commented 3 years ago

@vbatts items 1 and 2 are now done (#728)

Can you tell a bit more about item 3? I read https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners but I don't quite get the benefits of using CODEOWNERS.

I guess item 4 can be implemented now -- can you please do it?

kolyshkin commented 2 years ago

I have removed pullapprove integration, instead enabling master branch protection rules (two LGTMs from maintainers are required to merge a PR, no direct pushes are allowed, etc).

@vbatts can you please elaborate on CODEOWNERS? As per my older comment,

I read https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners but I don't quite get the benefits of using CODEOWNERS.

vbatts commented 2 years ago

whoa sorry (since October 😓 ) CODEOWNERS is being used to migrate off of pullapprove (and whatever), to use the built in github approval configuration