search

opencontainers / runtime-tools

OCI Runtime Tools
https://www.opencontainers.org/
Apache License 2.0
434 stars 141 forks source link

Revert "validation: fix/rename ReadStandardStreams" #735

Closed flouthoc closed 2 years ago

flouthoc commented 3 years ago

Hi Team,

I think commit https://github.com/opencontainers/runtime-tools/commit/0ab61aed92a67a6e72b68fc0dd6322c95e4bb05b introduces an issue with latest build of runtime-tools. Please find more details here https://github.com/containers/crun/pull/760

Could we please revert this commit.

Thanks

giuseppe commented 3 years ago

@kolyshkin PTAL

flouthoc commented 3 years ago

adding additional commit to fix linting issue in the revert

flouthoc commented 3 years ago

Fixed lint issue in a separate commit. @kolyshkin PTAL

kolyshkin commented 3 years ago

@flouthoc thanks! Were you able to figure out what's wrong with 0ab61ae? I am looking into it but maybe you can save me some time :)

flouthoc commented 3 years ago

@kolyshkin I first thought its the read from r.bundleDir(), fmt.Sprintf("stdout-%s", id)) and tried replicating to read from same format into the byte buffer. But unfortunately it did not fix the issue. So even i was not able to wrap my head around what is breaking things here hence decided to file a revert PR.

flouthoc commented 3 years ago

@kolyshkin Not blocked on this :) we locked CI to last working commit. Please take your time.

I'll still resolve nits on PR just in case if you ever want to quickly close the issue for upstream.