search

opencontainers / runtime-tools

OCI Runtime Tools
https://www.opencontainers.org/
Apache License 2.0
434 stars 141 forks source link

dependency: copy external tap-go package as an internal package #766

Closed fmuyassarov closed 1 year ago

fmuyassarov commented 1 year ago

This PR fixes subset of the dependency issues described in https://github.com/opencontainers/runtime-tools/issues/758.

Move/copy external tap-go package from github.com/mndrix/tap-go to be in tree package. github.com/mndrix/tap-go is no longer maintained and it is currently archived. Also, bump gopkg.in/yaml.v2 to gopkg.in/yaml.v3.

fmuyassarov commented 1 year ago

cc @klihub

fmuyassarov commented 1 year ago

ping @mrunalp @kolyshkin

thaJeztah commented 1 year ago

(sorry for drive by comment)

Instead of a straight copy/paste of the code, perhaps it would be good to migrate the code including history (see https://github.com/moby/sys/pull/121 for an example)

Perhaps also separating the integration commits from the follow ups (formatting build tags, upgrading yaml dependency)

fmuyassarov commented 1 year ago

@thaJeztah sorry for my late response on this, I was on PTO. I will update my patch as you suggested.

thaJeztah commented 1 year ago

@fmuyassarov no worries!

Also feel free to "ping" me if you need help with those instructions; I know it can be a bit of a pain to do (and make sure you use temporary repositories on your local machine), but I think it's good to a) preserve history (which can be relevant), and b) preserve the original commits to accredit the authors of those commits.

fmuyassarov commented 1 year ago

@fmuyassarov no worries!

Also feel free to "ping" me if you need help with those instructions; I know it can be a bit of a pain to do (and make sure you use temporary repositories on your local machine), but I think it's good to a) preserve history (which can be relevant), and b) preserve the original commits to accredit the authors of those commits.

+1