Closed cyphar closed 2 days ago
Yeah, it turns out depending on the behaviour of errors.Wrap(nil, ...)
was a bad idea... It might be a good idea to make our own wrapper for now to avoid too much pain, but making it a proper printf wrapper would require us to parse the format string...
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 32.98429%
with 384 lines
in your changes missing coverage. Please review.
Project coverage is 72.43%. Comparing base (
094e766
) to head (e9fff47
). Report is 11 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
This patchset adds and removes pkg/fmtcompat
. I think that it makes it easier to review, so I think it makes sense to keep it (otherwise you would need to do everything in one big patch or rework things in a somewhat unnatural way, otherwise you'll end up with broken commits if you bisect).
Fixes #388