opencontrol / compliance-masonry

Security Documentation Builder
Other
348 stars 82 forks source link

Tag and release master (post 1.1.2)? #264

Closed phillbaker closed 6 years ago

phillbaker commented 7 years ago

Hello and thanks for all of your hard work on compliance-masonry - it's a great idea.

I wanted to follow up on the comment in https://github.com/opencontrol/compliance-masonry/issues/239 which mentioned tagging/releasing a new version - there's some great code on master that would be great to get officially tagged and released, is there any timeline for publishing a new release?

(We also use a homebrew recipe which pulls from the releases, which would benefit from a release.)

shawndwells commented 6 years ago

bumping the conversation here per @afeld

shawndwells commented 6 years ago

Did a local build on a clean dev box, and noticing that lots of compliance-masonry's dependencies have been removed. Will complicate a new version...

 dep ensure
grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/metaleap/go-util-misc: no valid source could be created:
    failed to set up sources from the following URLs:
https://github.com/metaleap/go-util-misc
: remote repository at https://github.com/metaleap/go-util-misc does not exist, or is inaccessible: fatal: could not read Username for 'https://github.com': terminal prompts disabled
: exit status 128
    failed to set up sources from the following URLs:
ssh://git@github.com/metaleap/go-util-misc
: remote repository at ssh://git@github.com/metaleap/go-util-misc does not exist, or is inaccessible: ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
: exit status 128
    failed to set up sources from the following URLs:
git://github.com/metaleap/go-util-misc
: remote repository at git://github.com/metaleap/go-util-misc does not exist, or is inaccessible: fatal: remote error:
  Repository not found.
: exit status 128
    failed to set up sources from the following URLs:
http://github.com/metaleap/go-util-misc
: remote repository at http://github.com/metaleap/go-util-misc does not exist, or is inaccessible: fatal: could not read Username for 'https://github.com': terminal prompts disabled
: exit status 128

--edit-- Also:

$ go get -t ./...
# cd .; git clone https://github.com/go-utils/ufs /usr/local/opt/go/src/github.com/go-utils/ufs
Cloning into '/usr/local/opt/go/src/github.com/go-utils/ufs'...
fatal: could not read Username for 'https://github.com': terminal prompts disabled
package github.com/go-utils/ufs: exit status 128
rogeruiz commented 6 years ago

I found this too, and it seems like we'll possibly just need to modify where these deps are. but you're right this certainly complicates things.

https://github.com/opencontrol/compliance-masonry/pull/272

shawndwells commented 6 years ago

@rogeruiz you just did a rebuild... any secret to where these can be found? Technically I have them on my primary dev machine, and could copy things around... but seems overly hackish.

rogeruiz commented 6 years ago

this is what I relied on as well. I tried first to build the project from source, but ran into the same problems you mentioned.

rogeruiz commented 6 years ago

@shawndwells just cloned down a new version of this with a different $GOPATH and was able to get it building again after #272 was added to the master branch. Everything seems to be in order.

In order to cut a new release, proposing v1.2.0, we'll need to make sure that projects that are using compliance-masonry are still working. I'm going to go through the list of full project examples to verify this.

If it's all good, we can cut a new release and hopefully keep releasing changes as they land on master in a structured and automated way.

shawndwells commented 6 years ago

Given the recent build system updates from @redhatrises (thank you!!), new release can easily be created. Closing this issue. Thanks again @rogeruiz for creating the releases in April.