fix: update oci source label

MindTooth commented 3 months ago

What does this PR change?

Set the OCI source label to this repo.

Does this PR relate to any other PRs?

N/A.

How will this PR impact users?

Since I've worked on this for Renovate, people might loose grouping of this and normal opencost image. However, I plan to push an update to Renovate as well to fix this.

Does this PR address any GitHub or Zendesk issues?

N/A.

How was this PR tested?

docker build -t opencost-ui .
docker inspect opencost-ui

            "Labels": {
                "maintainer": "NGINX Docker Maintainers <docker-maint@nginx.com>",
                "org.opencontainers.image.description": "Cross-cloud cost allocation models for Kubernetes workloads",
                "org.opencontainers.image.documentation": "https://opencost.io/docs/",
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.source": "https://github.com/opencost/opencost-ui",
                "org.opencontainers.image.title": "opencost-ui",
                "org.opencontainers.image.url": "https://opencost.io"
            },

Does this PR require changes to documentation?

N/A.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

N/A.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
opencost-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 8, 2024 7:13pm

MindTooth commented 3 months ago

This is still Apache 2.0 right?

Ed1t: just a quick question, will there ever be tagged releases of this project that is the same as opencost/opencost? I see perhaps now that changing this might break getting changelogs as Renovate will be unable to compare releases. 🤔

mattray commented 3 months ago

This is still Apache 2.0 right?

Ed1t: just a quick question, will there ever be tagged releases of this project that is the same as opencost/opencost? I see perhaps now that changing this might break getting changelogs as Renovate will be unable to compare releases. 🤔

Yes it is still Apache 2.0, I've opened this PR for it: https://github.com/opencost/opencost-ui/pull/19

The plan is to continue to tag and release in sync with opencost/opencost releases

MindTooth commented 3 months ago

Thanks.

I plan to submit a PR for a replacement with Renovate to rewrite from quay.io to ghcr.io. However, as I see it, that is only applicable for the opencost-ui and not the cost model as it's used by kubecost too?

    {
      "matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
      "replacementName": "ghcr.io/opencost/opencost-ui",
      "replacementVersion": "1.109.0"
    }

MindTooth commented 3 months ago

Now added to Renovate 37.401.6. 🥳

mattray commented 3 months ago

Thanks.

I plan to submit a PR for a replacement with Renovate to rewrite from quay.io to ghcr.io. However, as I see it, that is only applicable for the opencost-ui and not the cost model as it's used by kubecost too?

We officially switched OpenCost from quay.io to ghcr.io with the 1.109.0 release, but packages are still being published on quay.io for folks who haven't switched over yet. opencost-ui won't be published to quay.io.

MindTooth commented 3 months ago

Having a replacement for quay.io/repository/kubecost1/kubecost-cost-model to ghcr.io/opencost/opencost will not be correct as older versions of kubecost also uses/used it?

Btw., publishing to quay has been disabled for a while now. At least it’s commented out in the workflow for build-publish.

mattray commented 3 months ago

Kubecost maintains their own packaging repositories, the use of "kubecost-cost-model" was a legacy name and is no longer used by them.

On Tue, Jun 11, 2024 at 9:30 PM Birger J. Nordølum @.***> wrote:

Having a replacement for quay.io/repository/kubecost1/kubecost-cost-model to ghcr.io/opencost/opencost will not be correct as older versions of kubecost also uses/used it?

Btw., publishing to quay has been disabled for a while now. At least it’s commented out in the workflow for build-publish.

— Reply to this email directly, view it on GitHub https://github.com/opencost/opencost-ui/pull/18#issuecomment-2160510607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQSJ53TZMBCLSURHOYGYDZG3NVLAVCNFSM6AAAAABJAGVGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGUYTANRQG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

MindTooth commented 3 months ago

So, to close this.

Are you okay with a Renovate replacement for kubecost-cost-model too? Meaning, we will have the following:

    {
      "matchPackageNames": ["quay.io/kubecost1/kubecost-cost-model"],
      "replacementName": "ghcr.io/opencost/opencost",
      "replacementVersion": "1.109.0"
    },
    {
      "matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
      "replacementName": "ghcr.io/opencost/opencost-ui",
      "replacementVersion": "1.109.0"
    }

That way, when Renovate is used, we can help people move over to the correct registry/image. replacementVersion must be the oldest know version that uses the new location.

mattray commented 3 months ago

That looks good except opencost-ui was just moved, so you would want the replacementVersion to be "1.110.0"

opencost / opencost-ui