opencpn-radar-pi / radar_pi

Radar plugin for OpenCPN with support for Navico and some Garmin and Raymarine radars
GNU General Public License v2.0
77 stars 43 forks source link

Garmin xHDnot shutting down on OpenCPN close #256

Open rszemeti opened 8 months ago

rszemeti commented 8 months ago

I am running OpenCPN 5.8.4, radar 5.5.0 ... with a Garmin GMR 18HD+ selected as xHD type.

If the radar is on and active, when I close OpenCPN it does not send a stop command and the radar keeps on spinning ...

keesverruijt commented 8 months ago

We don’t send a command on purpose, you may have other stations looking at the data.

Observing and keeping count of others is currently out-of-scope for us.

Suggestion: put a switch in the activation line feeding the RJ45 coupler.

rszemeti commented 8 months ago

I don't have any other stations looking at data, I suspect 99% of installations are a single station.

Would it not be possible to have a "stop radar on close" checkbox .. or better still use a GPIO to close the switch when the radar plugin is active?

Adding manual switches to do things is fine, but when we have a computer that can do it for us (and not forget to do it ... which is what happens when you give the job to a human ... )

Hakansv commented 8 months ago

It seems you're on a RPi? Why not investigate Tony's (Antipole) plugin "JavaScript " to serve this?

keesverruijt commented 8 months ago

I guess we could at a “stop radar on shutdown” button to the preferences, for all radars. It’s not necessary for most as they stop for themselves when we don’t ping them.

rszemeti commented 8 months ago

Let me try leaving it running and see if it stops itself after some time, maybe it is a non-issue.

rszemeti commented 8 months ago

Well, it's still whirring away an hour later, so let's put that down as a "nope" then.

I've had a look at the Javascript plugin, but struggling to work out how to get it a) trigger on application close, b) keep the application alive until it has finsihed doing whatever it needs to do and c) call the appropriate method in the radar plugin!