search

opencredit / BadgeOS-Community-Add-on

The "BadgeOS Community Add-on" integrates BadgeOS features into BuddyPress and bbPress. Site members complete achievements and earn badges based on a range of community activity and triggers. This add-on to BadgeOS also includes the ability to display badges and achievements on user profiles and activity feeds.
GNU Affero General Public License v3.0
11 stars 8 forks source link

fix join_group trigger for private groups #47

Closed cherbst closed 9 years ago

cherbst commented 9 years ago

also trigger join_group if user accepts an invitation or a membership request gets accepted

tw2113 commented 9 years ago

This is in conjunction with https://github.com/opencredit/BadgeOS-Community-Add-on/issues/19 correct?

cherbst commented 9 years ago

Correct, I did apply the patch to fix #19 before, so lines 144 to 146 come from this patch. As a result, my fix should already work with the join_specific_group trigger.

tw2113 commented 9 years ago

I assume you have tested this out with the rest, but I want to just get confirmation there.

Lastly, do you think you could do the pull request against the 19-join-specific-group-fix branch? That fix hasn't been fully merged in yet either, and may as well keep them together.

cherbst commented 9 years ago

I have created the new pull request #48. I have tested this fix with group invitation and request memberships, not with all possible triggers. But as this patch mainly adds actions to hooks that were not used before, I don't think it will introduce any regressions. Additionally, we are using this in production right now on a site with around 1k users. If any regressions happen, I will inform you.

tw2113 commented 9 years ago

Closing as we took it in on the other one.