Cannot search id of mother/father/ spouse except for informant and deceased for death declaration

[SyedaAfrida]

Bug description: Cannot search id of mother/father/ spouse except for informant and deceased for death declaration

Steps to reproduce:

1. Login to FA/ RA/ Registrar
2. Click search option
3. Select ID
4. Enter mother/father/ spouse ID except for informant and deceased of any death declaration
5. Search

Actual result: Cannot search id of mother/father/ spouse except for informant and deceased for death declaration

Expected result: Should be able to search id of mother/father/ spouse for death declaration, as we have option to search names of mother/father/ spouse for death declaration

Screen recording:

https://github.com/opencrvs/opencrvs-core/assets/94350336/ac7d57d9-43d9-462c-8e57-f9947d7a9abd

Tested on: https://login.farajaland-qa.opencrvs.org/?lang=en

[SyedaAfrida]

@Zangetsu101 @euanmillar Please ingvastigate why its happening, we can not test this right now.

[jpye-finch]

No UI Design required. All ID should be searchable. Mother, Father, Spouse, Informant, Deceased, Child (Country could add this in their form config. As the child maybe 10 years old with an ID already...)

[naftis]

For me, using latest develop and Farajaland, having deceased 0000000001, mother 0000000002 and spouse 0000000003 national id's, I was only able to find mother.

At least one underlying issue is that https://github.com/opencrvs/opencrvs-core/blob/fc2594d8e414816f41e00951fb06bb17af2b281a/packages/search/src/features/registration/death/service.ts#L147 this function saves BRN instead of the correct identifier

A proper fix for this is to save all the identifiers in ElasticSearch in an array.

[euanmillar]

@naftis @rikukissa I think we need to go ahead with that solution and build a migration for it. This is a bug we must resolve in either this release or 1.6.0 at the latest @SyedaAfrida

[naftis]

1.6.0 has the ElasticSearch reindexing functionality which would make this fix easier to handle without a migration.

[euanmillar]

@euanmillar to test this in Niue for mother and father

[tiri39]

Found the following issue in Farajaland qa env -

• When 'Birth Registration Number' is chosen as 'Type of ID' (for deceased/ informant/ spouse) , the declaration can't be found by searching using that ID.

[tiri39]

• @euanmillar need to test this in Niue for mother and father
• The issue found in Farajaland is fixed.