opencrvs / opencrvs-core

A global solution to civil registration
https://www.opencrvs.org
Other
85 stars 67 forks source link

rate-limiting: Disallow calling auth via external network #6178

Open naftis opened 10 months ago

naftis commented 10 months ago

Depends on this issue https://github.com/opencrvs/opencrvs-core/issues/5930 which allows proxying auth requests through gateway. For security, we should hide auth completely behind gateway to always rate limit it.

Dev tasks

euanmillar commented 7 months ago

Seeding should be fixed. Data generator should not be affected because it will not hit the limit.

Because we dont want to clear prod and run seeding / data gen there again ...

To code review this, we would need to provision another production "demo" environment where NODE_ENV is production and QA env var is also true, in order to test that seeding & data-generator work

If there is a problem ...

How about we allow "demo" scope to bypass rate limiting in order to enable the data-generator.