Make informant signature conditional based on supporting documentation

[euanmillar]

Death registration form change

• The digital signature section for the Notifier should not be shown on the Review page if the paper form is uploaded as a supporting document since the Notifier already signed on the paper form.

[Zangetsu101]

I'm moving this to backlog as this requires tech design

[Zangetsu101]

• Do we want the signatures as form fields or do we want them only for the review page?
• if form fields then are we allowing countries to add any form field to the review section e.g. an input field? @jpye-finch

[jpye-finch]

In reply to bullet 1: Having the signatures as form fields has been discussed. But they are best located on the review page. So conditionality between the form and review page is being asked for here

bullet 2: Good question. Think best to only allow signatures. Don't see a use case for allowing other form field inputs.

[rikukissa]

Some initial exploration work done in ocrvs-6821.

Tasks

• Implement functionality for fetching the preview section from country config. This primarily touches on two modules:

  • [x] Form reducer - In form reducer, remove the logic that adds the preview section as one of the form sections. Copy the current default config to country config's birth, death, marriage form definitions.
  • [x] Form validator in config microservice - Make required modifications to support having "preview" type form sections in config. Add validation logic to ensure all form configs always define one section with "preview" type and "preview" id. Inside of this section there must a group with an id "preview-view-group". More about error message later on in the task.

• [x] Move signature fields out from ReviewSection completely, introduce SIGNATURE as new form input type.

• [x] Add a generic field query/mutation transformer for redirecting the value from preview section to registration section. Signature inputs in the default example configurations should write and read signature data from the same fields as today.

• [x] Refactor the double-key informantsSignatureURI + informantsSignature to always only be informantsSignatureURI. Ultimately the Base64 data is also just an URI and should be treaded as such.

• [x] Add a backend validation error if preview section is not defined, guide user in local environment to add the fields that are today added by core automatically. These will be new non-custom fields in the form configuration.

• [x] Validation error for when there are no form section with "preview" type should (in local environments) instruct the user to copy paste an example configuration that produces 100% identical output to how the signature inputs render and function today.

• [x] Remove isSignatureMissing type logic and replace with regular form validation. Verify record cant submit before signature is placed.

Next phase

Implement image upload to Minio for custom fields

Bug?

https://github.com/opencrvs/opencrvs-core/blob/develop/packages/client/src/views/RegisterForm/review/ReviewSection.tsx#L2114-L2115