opencrvs / opencrvs-core

A global solution to civil registration
https://www.opencrvs.org
Other
88 stars 71 forks source link

Translations in countries are not reflected in the certificate for place of birth #6989

Open euanmillar opened 6 months ago

euanmillar commented 6 months ago

Description:

If you change the translation of a country name and select that as the place of birth for an individual, the translation is not reflected in the certificate. In this example I changed “Finland” to “RikuPyryLand” :-D. The cert still says “Finland”.

Screenshot 2024-05-14 at 18 05 17

Screenshot 2024-05-14 at 17 57 31

Notice the cert still says "Finland":

Screenshot 2024-05-14 at 17 58 29

This is because we dont pass intl to the eventLocationAddressFHIRPropertyTemplateTransformer and then the setAddressPropFromFHIRProp function.

I think that this could affect country translations in other places in the front end where I see countries imported like this and not used with intl.

import { countries } from '@client/utils/countries'

Its minor for births I think, but for deaths, if you wanted to show place of birth of deceased and have it translated, we would have a translation problem.

Which feature of OpenCRVS your bug concern?

Certification

To Reproduce Steps to reproduce the behaviour:

  1. Change a country translation in client.csv
  2. Register a birth and select place of birth to be the renamed country
  3. Download and print certificate
  4. Notice that the core hardcoded translation is used for the country name on the cert

Expected behaviour The translated copy from client.csv should be used for country name on the cert

OpenCRVS Core Version:

v1.4.1

euanmillar commented 6 months ago

Definitely a dependency on: https://github.com/opencrvs/opencrvs-core/issues/4123

Zangetsu101 commented 4 months ago

@euanmillar to test this one