Open rikukissa opened 3 months ago
export OPENCRVS_METABASE_MAP_NAME=${OPENCRVS_METABASE_MAP_NAME:-"Farajaland"}
export OPENCRVS_METABASE_MAP_URL=${OPENCRVS_METABASE_MAP_URL:-"http://localhost:3040/content/farajaland-map.geojson"}
I noticed there's also the Farajaland map name. Confirming that changing the map name doesn't seem so important, as that naming doesn't leak into the country config code?
@naftis Good spot. Let's change the country map name to "Full country" for now.
It affects these views in Metabase:
@euanmillar there's potentially a documentation change required here: now the local dashboard is served from http://localhost:3040/content/map.geojson
This is to promote replacing that file from country config, instead of adding a new one and re-configuring the URL in the Metabase admin panel, as the reconfigured one will be overridden from the persisted files when Metabase is reloaded.
We need to make sure that the dashboard maps are still working
Describe the bug When configuring Metabase, many countries might want to change the URL from where the GeoJSON of their countries map is fetched from. In development this defaults to http://localhost:3040/content/farajaland-map.geojson.
For production, we've built an additional system to overwrite these values with environment variables so that the addresses can be different in different environments. The issue is, that this same mechanism is also in use in the local environment with variable values hard-coded to match Farajaland values.
Which feature of OpenCRVS your bug concern? Dashboards customisation
To Reproduce Steps to reproduce the behaviour:
Expected behaviour You should now see the map URL persisted to be the one you previously set.
Actual behaviour You see it has reverted back to http://localhost:3040/content/farajaland-map.geojson
OpenCRVS Core Version:
Tech design
http://localhost:3040/content/map.geojson"
. Apply the same fix and change endpoint urls in country config and Farajaland