opencrvs / opencrvs-core

A global solution to civil registration
https://www.opencrvs.org
Other
85 stars 67 forks source link

Wrong status shown in the Comparison View Page of duplicate record. #7439

Closed tiri39 closed 19 hours ago

tiri39 commented 1 month ago

Bug description: When a duplicated record is 'marked as duplicate', its status becomes 'archived'. Then if we reinstate the record, the status becomes 'In review'. But it shows 'archived' in the comparison view page.

Steps to reproduce:

  1. Login as RA / registrar.
  2. Navigate to the 'Ready for Review' workqueue.
  3. Navigate to the Review page of a duplicate record and mark it as a duplicate.
  4. Search the record by tracking id and Reinstate it.
  5. Navigate to the review page of the reinstated record.
  6. Select any tracking id to see the comparison view.
  7. In the comparison view page, observe the status of the duplicate record.

Actual result: The status is 'archived'

Expected result: The status should be 'In review'.

Screen recording:

https://github.com/user-attachments/assets/f008143a-cf21-4b08-8fef-98e34547a2a2

Tested on: https://login.farajaland-qa.opencrvs.org/?lang=en

Version: v1.6.0

Siyasanga commented 1 month ago

@tiri39 It looks like the actual status was supposed to be the last one that was set e.g Declared for the example above instead of In review. It looks like we don't have that status as an option for RegistrationStatus e.g here is a list of posible declaration status that I found in code

export enum RegStatus {
  Archived = 'ARCHIVED',
  Certified = 'CERTIFIED',
  CorrectionRequested = 'CORRECTION_REQUESTED',
  DeclarationUpdated = 'DECLARATION_UPDATED',
  Declared = 'DECLARED',
  InProgress = 'IN_PROGRESS',
  Issued = 'ISSUED',
  Registered = 'REGISTERED',
  Rejected = 'REJECTED',
  Validated = 'VALIDATED',
  WaitingValidation = 'WAITING_VALIDATION'
}
tiri39 commented 1 month ago

@Siyasanga It seems using 'declared' would show 'In review' in UI. So, 'declared' can be used here.