refactor: fix failing e2e test for all places referencing a full name

opencrvs / opencrvs-farajaland

An example configuration module for OpenCRVS using a fictional country

https://www.opencrvs.org/

Other

9 stars 17 forks source link

refactor: fix failing e2e test for all places referencing a full name #1164

Open Siyasanga opened 2 weeks ago

Siyasanga commented 2 weeks ago

Fix e2e tests after introducing a way to allow countries to customise the order of a full name. turns out there were alot of other screens that use a full name so the changes to the formatName() broke a lot of e2e tests. Instead of fixing the tests we've put temporary logic fullNameWithFirstNameFirst() helper function which will get removed once all the screens use the formatName() function.

https://github.com/opencrvs/opencrvs-core/issues/6830

github-actions[bot] commented 2 weeks ago

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

ocrvs-bot commented 2 weeks ago

Your environment is deployed to https://ocrvs-6830-human-name-constant.opencrvs.dev.